* Fix: fixed some error must be last param

* Refactor: continued refactoring according to golint

* Refactor: addresses more golint warnings

* Refactor: refactored error last

* Fix: fixed hive.go

* Refactor: refactored alot according to golang-ci-list

* Refactor: intermediary commit

* Refactor: refactored additional code according to golint-ci

* Refactor: continued to refactor according to golint

* Refactor: refactored according to golint

* Fix: fixed last golinter reports

* assure that DropNeighbor is not leaking

* bind events to gossip plugin

* make the gossip manager a singleton

* add comment

* fix manager instantiation

* trigger event while locked

* add dropNeighbor test

* Fix name

Co-Authored-By: Luca Moser <moser.luca@gmail.com>

* Rename AllNeighbors

* fix linter warnings

Co-authored-by: Luca Moser <moser.luca@gmail.com>

* replace 'transaction' with 'message' in message layer pkg

* remove more occurrences of 'transaction'

* fixes ReferencedMessageId() returning approverMessageId

* renames ApprovingMessageId to ApproverMessageId

* use ApproverMessageId in deleteFureCone()

* refactors message pkg

* renames payloadId in Message to contentId

* finalize comment on what a Message is

* refactors additional message sub pkgs

* renames 'transaction' to 'message' in gossip plugin

* removes occurrences of 'transaction' in graph plugin

* removes occurrences of 'transaction' in metrics plugin

* refactors dashboard plugin for messages

* removes further occurrences where tx is used instead of msg

* fixes TestMessageRequest in manager_test.go

* go fmt explorer_routes.go

* fix review comments

* fix Errorf order

* throw around bones

* Move marshalutil to hive.go

* Refactor existing code (before binary) to use new hive.go/identity #282

* Adjust binary code to use hive.go/identity and remove signature/ed25519 #282

* Adjust moved files from merge to use hive.go/marshalutil

* Adjust moved files from merge to use hive.go/identity and hive.go/crypto

* Adjust for changes in hive.go

* Fix: fixed a bug due to refactor

Co-authored-by: Hans Moog <hm@mkjc.net>

* Feat: started reworking output model

* Refactor: refactored some of the model

* Refactor: started to refactor some additional models

* Refactor: started to refactor message layer

* Refactor: still refactoring :/

* Refactor: refactored some more

* Refactor: some error messages are gone YAY

* Refactor: refactor complete

* upgrade hive.go

* adapt to hive autopeering changes

* use fixed version

* check for valid gossip service

* fix linter warnings

* use netutil to check port number

* clean up code

* adjust autopeering port check

* update hive.go

* use a new discovery instance

* set network ID

* increase DB version

* upgrade hive.go

* Feat: refactored the address

* Feat: started adding solidification of transferOutputs

* Feat: cleaned up checker code

* Feat: going to bed - good night world

* Feat: refactored transferoutput package

* Fix: fixed a bug from refactoring

* Refactor: removed old transferoutputmetadata package

* Refactor: started refactoring transfer package

* Refactor: refactored transfer/id package

* Refactor: moved transfer struct to new package

* Refactor: fixed issues after refactor

* Refactor: fixed sth

* Refactor: continued to move files

* Refactor: commit before migration of last refactored files

* Refactor: another refactor before move

* Refactor: refactor test

* Fix: fixed some bugs connected to refactor

* Refactor: continued refactor

* Refactor: fixed some bugs

* Refactor: does it work now?

* Feat: added a method to generate a random transferid

* Feat: rename transfer to transaction

* Refactor: refactor according to new names

* Refactor: continued to refactor transaction package

* Refactor: moved payload id to payload package

* Refactor: moved signatures to transaction package

* Refactor: moved signature to transaction

* Fix: fixed bug due to refactor

* Fix: fixed bugs due to refactor

* Refactor: fixed some bugs after refactor

* Fix: fixed additional bugs

* Fix: bug fix

* Refactor: moved signature to signaturescheme package

* Fix: fixed signatures test

* Fix: fixed bug in tangle

* Fix: fixed payloadmetadata test

* Fix: fixed payload test

* Refactor: moved payloadmetadata to payload package

* Fix: fixed some refactor bugs

* Fix: fixed a bug due to refactor

* Fix: fixed broken test

* Refactor: moved approver to payload package

* Refactor: moved missingpayload to payload package

* Refactor: refactored coloredbalance package

* Fix: fixed bug due to refactor

* Refactor: moved address signaturescheme to address package

* Fix: fixed refactor bug

* Feat: added missing outputs to tangle

* Fix: fixed issues due to refactor

* Refactor: started moving tangle classes to tangle package

* Refactor: moved payloadmetadata to tangle

* Fix: fixed bugs due to refactor

* Refactor: moved TransactionMetadata to tangle package

* Refactor: moved some files to tangle

* Fix: fixed bug due to refactor

* Feat: added TransactionMetadata storage

* Fix: fixed some issues

* Fix: fixed some issues

* Fix: fixed missing release

* Refactor: cleaned up unused files

* Refactor: changing branches (need to commit)

* Refactor: refactored some code

* Feat: finished signature scheme for value transactions

* Fix: fix broken merge

* Refactor: refactored some code

* Refactor: refactored transaction marshaling and unmarshaling

* Fix: fixed missing err check

* Feat: added payload string method

* Feat: added Bytes() method to transactionid

* Migrate netutil package to hive.go #282

* Fix tests

* use db in tempdir

Co-authored-by: Wolfgang Welz <welzwo@gmail.com>

* Feat: started to merge changes

* Refactor: moved parameter package to be a plugin (same with logger)

* Feat: first compiling version of new ontologoies merge

* Feat: ported additional plugins

* Feat: transaction get solid now

* Refactor: reverted some previous changes from debugging

* Feat: added a banner module for the cli interface

* Feat: added a plugin for the port checks

* Feat: fixed some bugs

* Refactor: reverted some changes

* Feat: reworked TransactionParser to use Errors

* Feat: TransactionParser uses Peer

* Feat: started to rework broadCastData webapi call

* Feat: refactored some plugins

* Fix: fixed test of tangle

* Refactor: changed tangle package in graph plugin

* Refactor: uncommented broken code

* Fix: fixed broken method signature in gossip test

* Feat: started adding value tangle

* Feat: adjusted to new hive.go

* Feat: upgraded hive.go

* Clean up PortCheck plugin and make it standalone #259 (#271)

Co-authored-by: Hans Moog <hm@mkjc.net>

Co-authored-by: Jonas Theis <mail@jonastheis.de>

* Fix: Log dropping packets every 1000 drops

* use an atomic counter for dropped message because Write() could be called concurrently

* removes redundant zero

* Add external check in test

Co-authored-by: Luca Moser <moser.luca@gmail.com>

* use autopeering from hive.go
* update hive.go

* fixes locks not getting unlocked

* only hold the lock in DropNeighbor while deleted the neighbor entry

* log connection failed error

* fixes tests

* fixes locks not getting unlocked

* only hold the lock in DropNeighbor while deleted the neighbor entry

* fix close order

* return closed error

* fix tests

* do not close send queue explicitly

* fix: store and load seeds from the peer DB

*  fix linter warnings

* Add map based database implementation

* Use mapdb for all autopeering tests

* Use buffered connection for gossip

* fix wrong timeout

* Encode length in big endian

*  Improve debug logging

* configure bind and external address

* Move bind and external to network

* Ignore empty seed

* Update default config

* Add bind address config for analysis http server

* Make graph config consistent

* Add bind address to dashboard

* Do not print config on startup

* Apply suggestions from code review

Co-Authored-By: Luca Moser <moser.luca@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Luca Moser <moser.luca@gmail.com>

Co-authored-by: Luca Moser <moser.luca@gmail.com>

* fix: use netutil to check UDP connection

* Make ping private

* use public address from local

* add missing import

* update hive.go version

* repeat sends directly in protocol

* retry ping to ensure verified

* Apply suggestions from code review

Co-Authored-By: Luca Moser <moser.luca@gmail.com>

Co-authored-by: Luca Moser <moser.luca@gmail.com>

* feat: add netutil package

* use IsTemporaryError

* remove unused import

* refactors errors

* fmt packages/model/error.go

* fix: use queue for neighbor connection

* refactor: do not request transactions via event

* fix: remove unused connection

* chore: fix linter warnings

* feat: improve gossip events and logs

* fix: log after connection is closed

*  GetNextCandidate selection added

*  Recompile salt.proto

*  Refactor peer IDs completely

*  Recompile proto sources

*  WIP

*  renamed to sort

*  Return requested peers on request

*  Kepp track how ofter a managed peer was verified

*  sort adapted to the new peer

*  Query verified peers for new peers

*  WIP

*  Add manager tests

*  Add peering messages to protobuf

*  Make Salt methods consistent with Peer

*  Handle peering messages

*  WIP

*  Add To filed to PeersRequest

*  Add PeersRequest test

*  Adding PeersRequest benchmark

*  Move mpeer and helper functions to own file

*  Bump peer only once on reverification

*  WIP

* 

*  WIP

*  Increase buffer to prevent deadlocks

*  Remove unnecessary lock

*  Add peering request test

*  Make tests deterministic by triggering reverify

*  WIP

*  fixing concurrency issues

*  testManager improved

*  Don't send PeeringResponse for invalid salt

*  WIP

*  WIP

*  removed commented code

*  WIP

*  WIP

* Neighbourhood manager (#11)

*  GetNextCandidate selection added

*  fixing concurrency issues

*  testManager improved

*  removed commented code

*  WIP

*  WIP

*  WIP

*  WIP

*  Make TestAdd pass in neighborhood_test

`Add` should do nothing if the neighborhood list is full.

*  Improve TestSrvVerifyBoot

*  Upgrade to go 1.13

*  Use testify instead of magiconair/properties

* 

*  WIP

*  WIP

*  WIP

*  WIP

* Simulation (#14)

*  clear rejection filter after refreshing the public salt

*  clean rejection filter

*  Add mpeer test

*  gofmt test

*  Remove ineffactual assignments

*  Trigger panic when index is out of bound in deletePeer

*  Add selection test

*  Add TestGetFurtherest and TestGetPeerIndex

*  both salt updated at the same time and neighborhood dropped

*  Add node peering history for simulation

*  WIP

*  added sim visualization

*  removed root handler

*  added README

*  updated README

*  removed unused dependencies

*  Tidy go.mod

*  Work in progress

*  WIP

*  WIP

*  WIP

*  improved start button

*  WIP

*  added keyboard support for start

*  WIP

*  WIP

*  WIP

*  WIP

*  WIP

*  WIP

*  added input parameters

*  README updated

*  gif updated

*  figure updated

*  updated

*  updated gif

* removed simulation metrics

*  updated

*  updated

*  Extract server from discovery and peering

*  Use golang/protobuf

* Update README.md

*  Rename PeersRequest to DiscoveryRequest

*  Fixing typos

*  Move unused function to tests

*  The selection protocol depends on the discovery

*  Make tests more robust when using -race

*  Improve logging

*  Remove unnecessary arguments

*  Fix data races

*  added timeout for simulated network

*  added loop to animation

*  rename neighborhood to selection

*  adds initial salt and fixes simulation end

*  visualizer enabled by default

*  new parameter dropAll and improved python script

*  updated README

*  updated README

*  fix salt initialization

*  added blogpost link

*  Add badges to README

*  Add Travis CI for tests

*  Correct formating

*  Running golangci on Travis

*  Ignore return value of 'logger.Sync'

*  Remove unused functions

*  Add link to license

*  Move simnetwork to transport

*  Use the complete network protocol in simulations

*  Do not export selection/manager

*  Remove gRPC transport layer

*  Add UDP connection transport test

*  Implement the peer DB using Goshimmer database

*  Use the local GoShimmer version

*  Add support for a persistent database

*  Persist private key of local peer in database

*  Set TTL for bootstrap peers

*  Use GoShimmer events

*  Store the supported services in the local peer

*  Use most current GoShimmer git version as a dep

*  Switch to hive.go event package

*  Use correct module iotaledger/autopeering-sim

*  Provide dummy service in autopeering simulation

*  adds service support in the selection

*  adds peer discovered events

*  adds GetIncomingNeighbors and GetOutgoingNeighbors

*  fixes out of bound error in splitNodeKey

*  adds public IP support

*  fixes localhost

*  fixes localhost parsing

*  changes selection loop to 1s

*  switches from fmt.Println to log.Debug

*  increases maxKnown to 1000 and always triggers discovered peer

*  adds PeerDeleted event

*  moves PeerDeleted event into deletePeer

*  adds config paramters for the peer discovery

*  adds config parameters to neighbor selection

*  enable/disable inbound/outbound selection

*  Improve Godoc comments

*  modifies disabled outbound selection

*  fixes bug with disabling the selection

*  removes getMyIP() from server

*  removes some debugging logs

*  Introduce services

- Each peer now comes with a set of services
- Local peer is a proper peer
- Services are exchanged during Pong and are available for all verified
peers

*  fixes GetVerifiedPeer

*  adds gossip key to the service

*  removes debugging logs

*  Add test for GetVerifiedPeer

*  Fix main

*  Add localNetwork to Protocol

*  Add new but verified peers to the manager

*  changes configurable parameters

*  fixes DiscoveryRequest field sequence

*  Regenerate proto files

*  Cleanup parameters

*  Fix potential race condition

*  Reduce logging verbosity

*  Add test for selection+discover

*  Return net.Addr in Transport

*  Remove inbound/outbound switches completely

*  Improve logging

*  Fix peerdb logs

*  Fix peer updating

*  Make TestProtFull more robust

*  Make queryInterval a parameter

*  Improve loggind during querying

*  Trigger PeerDiscovered only for active peers

*  Cleanup protocol tests

*  Add discovery test on protocol level

*  Rename maxVerified to maxManaged

*  Increase default query interval

*  Improve discover benchmarks

*  Fix manager tests

*  Do not use bugged assert.Eventually

*  Fix linter warnings in server

*  Remove unused parameters

*  Make transport work on slices of bytes

*  Fix typo in comments

*  Fix linter warnings

*  UpdateService accepts two strings

*  Add test that services are received in discover

*  adds required services

*  Handle closed connections consistently

*  Code cleanup

*  fixes DropPeer

*  improves debug messages

*  Log errors during reverification

* 

 Log packet size

* refactor: remove unused files

* refactor: use internal autopeering package

Co-authored-by: Angelo Capossele <angelocapossele@gmail.com>
Co-authored-by: jkrvivian <jkrvivian@gmail.com>