Fixes linter warnings.

* Move marshalutil to hive.go

* Refactor existing code (before binary) to use new hive.go/identity #282

* Adjust binary code to use hive.go/identity and remove signature/ed25519 #282

* Adjust moved files from merge to use hive.go/marshalutil

* Adjust moved files from merge to use hive.go/identity and hive.go/crypto

* Adjust for changes in hive.go

* Fix: fixed a bug due to refactor

Co-authored-by: Hans Moog <hm@mkjc.net>

* upgrade hive.go

* adapt to hive autopeering changes

* use fixed version

* check for valid gossip service

* fix linter warnings

* use netutil to check port number

* clean up code

* adjust autopeering port check

* update hive.go

* use a new discovery instance

* set network ID

* increase DB version

* upgrade hive.go

* Migrate netutil package to hive.go #282

* Fix tests

* use db in tempdir

Co-authored-by: Wolfgang Welz <welzwo@gmail.com>

* Feat: started to merge changes

* Refactor: moved parameter package to be a plugin (same with logger)

* Feat: first compiling version of new ontologoies merge

* Feat: ported additional plugins

* Feat: transaction get solid now

* Refactor: reverted some previous changes from debugging

* Feat: added a banner module for the cli interface

* Feat: added a plugin for the port checks

* Feat: fixed some bugs

* Refactor: reverted some changes

* Feat: reworked TransactionParser to use Errors

* Feat: TransactionParser uses Peer

* Feat: started to rework broadCastData webapi call

* Feat: refactored some plugins

* Fix: fixed test of tangle

* Refactor: changed tangle package in graph plugin

* Refactor: uncommented broken code

* Fix: fixed broken method signature in gossip test

* Feat: started adding value tangle

* Feat: adjusted to new hive.go

* Feat: upgraded hive.go

* Clean up PortCheck plugin and make it standalone #259 (#271)

Co-authored-by: Hans Moog <hm@mkjc.net>

Co-authored-by: Jonas Theis <mail@jonastheis.de>

* use autopeering from hive.go
* update hive.go

* fixes locks not getting unlocked

* only hold the lock in DropNeighbor while deleted the neighbor entry

* log connection failed error

* fixes tests

* fix: store and load seeds from the peer DB

*  fix linter warnings

* Add map based database implementation

* Use mapdb for all autopeering tests

* Use buffered connection for gossip

* fix wrong timeout

* Encode length in big endian

*  Improve debug logging

* configure bind and external address

* Move bind and external to network

* Ignore empty seed

* Update default config

* Add bind address config for analysis http server

* Make graph config consistent

* Add bind address to dashboard

* Do not print config on startup

* Apply suggestions from code review

Co-Authored-By: Luca Moser <moser.luca@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Luca Moser <moser.luca@gmail.com>

Co-authored-by: Luca Moser <moser.luca@gmail.com>

* fix: use netutil to check UDP connection

* Make ping private

* use public address from local

* add missing import

* update hive.go version

* repeat sends directly in protocol

* retry ping to ensure verified

* Apply suggestions from code review

Co-Authored-By: Luca Moser <moser.luca@gmail.com>

Co-authored-by: Luca Moser <moser.luca@gmail.com>

* feat: add netutil package

* use IsTemporaryError

* remove unused import

* 

 adds open port check

* Use gossip.server to check port

* Use same messages in gossip and autopeering

* Give correct error message when unreachable

Co-authored-by: Wolfgang Welz <welzwo@gmail.com>

* refactors errors

* fmt packages/model/error.go

* feat: add option to configure the private key seed

* Improve log messages

* fix: ignore rejected peering requests

* Do not store local services in DB

* Log failed connection attempts

* Only trigger drop event, when a neighbor was removed

* Remove unused dropNeighbors

* Use only one loop to process channels in selection

* Update out neighbors less often

* feat: introduce SaltUpdated event

* fix: use global parameters

* Update salt log messages

* fix: do not close public channels to prevent panics during shutdown

* fix: assure correct order of events

* feat: add selection event tests

* Set update interval to 1s and full updat interval to 1m

* Use subtests for the protocol tests

* fix: send peering drop message only when event is triggered

* Update packages/autopeering/selection/manager.go

Co-Authored-By: jkrvivian <jkrvivian@gmail.com>

Co-authored-by: jkrvivian <jkrvivian@gmail.com>

Signed-off-by: Luca Moser <moser.luca@gmail.com>

*  moves all webapi into one

*  adds public key log

*  changes txRequest to getTrytes

*  rename packages

*  adds comments

*  changes status to error

*  removes duration from API - getTrytes converts trits to trytes - set default spammer TPS to 1

Fix: Allow starting a node with gossip disabled (#97)

* fix: remove selection flag and use gossip plugin

* Upgrade hive.go

feat: improve logging

feat: improve analysis status

chore: remove unused packages (#99)

Fix: Use docker specific config (#100)

* Use docker specific config

* Format JSON

 removes status

 adds omitempty

 updates style import

 adds getNeighbors API

 adds getTransaction

 removes addEndpoint

*  WIP

*  WIP

*  adds txs per address

*  adds findTransactions API

* fix: remove selection flag and use gossip plugin

* Upgrade hive.go

* fix: use queue for neighbor connection

* refactor: do not request transactions via event

* fix: remove unused connection

* chore: fix linter warnings

* feat: improve gossip events and logs

* fix: log after connection is closed

*  GetNextCandidate selection added

*  Recompile salt.proto

*  Refactor peer IDs completely

*  Recompile proto sources

*  WIP

*  renamed to sort

*  Return requested peers on request

*  Kepp track how ofter a managed peer was verified

*  sort adapted to the new peer

*  Query verified peers for new peers

*  WIP

*  Add manager tests

*  Add peering messages to protobuf

*  Make Salt methods consistent with Peer

*  Handle peering messages

*  WIP

*  Add To filed to PeersRequest

*  Add PeersRequest test

*  Adding PeersRequest benchmark

*  Move mpeer and helper functions to own file

*  Bump peer only once on reverification

*  WIP

* 

*  WIP

*  Increase buffer to prevent deadlocks

*  Remove unnecessary lock

*  Add peering request test

*  Make tests deterministic by triggering reverify

*  WIP

*  fixing concurrency issues

*  testManager improved

*  Don't send PeeringResponse for invalid salt

*  WIP

*  WIP

*  removed commented code

*  WIP

*  WIP

* Neighbourhood manager (#11)

*  GetNextCandidate selection added

*  fixing concurrency issues

*  testManager improved

*  removed commented code

*  WIP

*  WIP

*  WIP

*  WIP

*  Make TestAdd pass in neighborhood_test

`Add` should do nothing if the neighborhood list is full.

*  Improve TestSrvVerifyBoot

*  Upgrade to go 1.13

*  Use testify instead of magiconair/properties

* 

*  WIP

*  WIP

*  WIP

*  WIP

* Simulation (#14)

*  clear rejection filter after refreshing the public salt

*  clean rejection filter

*  Add mpeer test

*  gofmt test

*  Remove ineffactual assignments

*  Trigger panic when index is out of bound in deletePeer

*  Add selection test

*  Add TestGetFurtherest and TestGetPeerIndex

*  both salt updated at the same time and neighborhood dropped

*  Add node peering history for simulation

*  WIP

*  added sim visualization

*  removed root handler

*  added README

*  updated README

*  removed unused dependencies

*  Tidy go.mod

*  Work in progress

*  WIP

*  WIP

*  WIP

*  improved start button

*  WIP

*  added keyboard support for start

*  WIP

*  WIP

*  WIP

*  WIP

*  WIP

*  WIP

*  added input parameters

*  README updated

*  gif updated

*  figure updated

*  updated

*  updated gif

* removed simulation metrics

*  updated

*  updated

*  Extract server from discovery and peering

*  Use golang/protobuf

* Update README.md

*  Rename PeersRequest to DiscoveryRequest

*  Fixing typos

*  Move unused function to tests

*  The selection protocol depends on the discovery

*  Make tests more robust when using -race

*  Improve logging

*  Remove unnecessary arguments

*  Fix data races

*  added timeout for simulated network

*  added loop to animation

*  rename neighborhood to selection

*  adds initial salt and fixes simulation end

*  visualizer enabled by default

*  new parameter dropAll and improved python script

*  updated README

*  updated README

*  fix salt initialization

*  added blogpost link

*  Add badges to README

*  Add Travis CI for tests

*  Correct formating

*  Running golangci on Travis

*  Ignore return value of 'logger.Sync'

*  Remove unused functions

*  Add link to license

*  Move simnetwork to transport

*  Use the complete network protocol in simulations

*  Do not export selection/manager

*  Remove gRPC transport layer

*  Add UDP connection transport test

*  Implement the peer DB using Goshimmer database

*  Use the local GoShimmer version

*  Add support for a persistent database

*  Persist private key of local peer in database

*  Set TTL for bootstrap peers

*  Use GoShimmer events

*  Store the supported services in the local peer

*  Use most current GoShimmer git version as a dep

*  Switch to hive.go event package

*  Use correct module iotaledger/autopeering-sim

*  Provide dummy service in autopeering simulation

*  adds service support in the selection

*  adds peer discovered events

*  adds GetIncomingNeighbors and GetOutgoingNeighbors

*  fixes out of bound error in splitNodeKey

*  adds public IP support

*  fixes localhost

*  fixes localhost parsing

*  changes selection loop to 1s

*  switches from fmt.Println to log.Debug

*  increases maxKnown to 1000 and always triggers discovered peer

*  adds PeerDeleted event

*  moves PeerDeleted event into deletePeer

*  adds config paramters for the peer discovery

*  adds config parameters to neighbor selection

*  enable/disable inbound/outbound selection

*  Improve Godoc comments

*  modifies disabled outbound selection

*  fixes bug with disabling the selection

*  removes getMyIP() from server

*  removes some debugging logs

*  Introduce services

- Each peer now comes with a set of services
- Local peer is a proper peer
- Services are exchanged during Pong and are available for all verified
peers

*  fixes GetVerifiedPeer

*  adds gossip key to the service

*  removes debugging logs

*  Add test for GetVerifiedPeer

*  Fix main

*  Add localNetwork to Protocol

*  Add new but verified peers to the manager

*  changes configurable parameters

*  fixes DiscoveryRequest field sequence

*  Regenerate proto files

*  Cleanup parameters

*  Fix potential race condition

*  Reduce logging verbosity

*  Add test for selection+discover

*  Return net.Addr in Transport

*  Remove inbound/outbound switches completely

*  Improve logging

*  Fix peerdb logs

*  Fix peer updating

*  Make TestProtFull more robust

*  Make queryInterval a parameter

*  Improve loggind during querying

*  Trigger PeerDiscovered only for active peers

*  Cleanup protocol tests

*  Add discovery test on protocol level

*  Rename maxVerified to maxManaged

*  Increase default query interval

*  Improve discover benchmarks

*  Fix manager tests

*  Do not use bugged assert.Eventually

*  Fix linter warnings in server

*  Remove unused parameters

*  Make transport work on slices of bytes

*  Fix typo in comments

*  Fix linter warnings

*  UpdateService accepts two strings

*  Add test that services are received in discover

*  adds required services

*  Handle closed connections consistently

*  Code cleanup

*  fixes DropPeer

*  improves debug messages

*  Log errors during reverification

* 

 Log packet size

* refactor: remove unused files

* refactor: use internal autopeering package

Co-authored-by: Angelo Capossele <angelocapossele@gmail.com>
Co-authored-by: jkrvivian <jkrvivian@gmail.com>