Refactor

dapps/valuetransfers/dapp.go

@@ -72,8 +72,6 @@ var (
 
 	valueObjectFactory     *tangle.ValueObjectFactory
 	valueObjectFactoryOnce sync.Once
-
-	SignatureFilter *tangle.SignatureFilter
 )
 
 // App gets the plugin instance.
@@ -171,8 +169,7 @@ func configure(_ *node.Plugin) {
 	}))
 
 	// register SignatureFilter in Parser
-	SignatureFilter = tangle.NewSignatureFilter()
-	messagelayer.MessageParser().AddMessageFilter(SignatureFilter)
+	messagelayer.MessageParser().AddMessageFilter(tangle.NewSignatureFilter())
 
 	// subscribe to message-layer
 	messagelayer.Tangle().Events.MessageSolid.Attach(events.NewClosure(onReceiveMessageFromMessageLayer))

packages/binary/messagelayer/messageparser/message_parser.go

@@ -21,11 +21,6 @@ type MessageParser struct {
 	messageFiltersModified typeutils.AtomicBool
 	bytesFiltersMutex      sync.Mutex
 	messageFiltersMutex    sync.Mutex
-
-	// only used for workerpool debugging
-	MessageSignatureFilter  *builtinfilters.MessageSignatureFilter
-	PowFilter               *builtinfilters.PowFilter
-	RecentlySeenBytesFilter *builtinfilters.RecentlySeenBytesFilter
 }
 
 // New creates a new message parser.
@@ -47,10 +42,8 @@ func New() (result *MessageParser) {
 	}
 
 	// add builtin filters
-	result.RecentlySeenBytesFilter = builtinfilters.NewRecentlySeenBytesFilter()
-	result.AddBytesFilter(result.RecentlySeenBytesFilter)
-	result.MessageSignatureFilter = builtinfilters.NewMessageSignatureFilter()
-	result.AddMessageFilter(result.MessageSignatureFilter)
+	result.AddBytesFilter(builtinfilters.NewRecentlySeenBytesFilter())
+	result.AddMessageFilter(builtinfilters.NewMessageSignatureFilter())
 	return
 }
 

plugins/pow/plugin.go

@@ -30,7 +30,6 @@ func run(*node.Plugin) {
 
 	log.Infof("%s started: difficult=%d", PluginName, difficulty)
 
-	messagelayer.MessageParser().PowFilter = builtinfilters.NewPowFilter(worker, difficulty)
-	messagelayer.MessageParser().AddBytesFilter(messagelayer.MessageParser().PowFilter)
+	messagelayer.MessageParser().AddBytesFilter(builtinfilters.NewPowFilter(worker, difficulty))
 	messagelayer.MessageFactory().SetWorker(messagefactory.WorkerFunc(DoPOW))
 }