Skip to content
Snippets Groups Projects
Unverified Commit 15efbce3 authored by capossele's avatar capossele
Browse files

:recycle: Disable filter workerpools

parent f6c3ead1
No related branches found
No related tags found
No related merge requests found
......@@ -28,33 +28,33 @@ func NewSignatureFilter() *SignatureFilter {
// Filter get's called whenever a new message is received. It rejects the message, if the message is not a valid value
// message.
func (filter *SignatureFilter) Filter(message *message.Message, peer *peer.Peer) {
filter.workerPool.Submit(func() {
// accept message if the message is not a value message (it will be checked by other filters)
valuePayload := message.Payload()
if valuePayload.Type() != payload.Type {
filter.getAcceptCallback()(message, peer)
// filter.workerPool.Submit(func() {
// accept message if the message is not a value message (it will be checked by other filters)
valuePayload := message.Payload()
if valuePayload.Type() != payload.Type {
filter.getAcceptCallback()(message, peer)
return
}
return
}
// reject if the payload can not be casted to a ValuePayload (invalid payload)
typeCastedValuePayload, ok := valuePayload.(*payload.Payload)
if !ok {
filter.getRejectCallback()(message, errors.New("invalid value message"), peer)
// reject if the payload can not be casted to a ValuePayload (invalid payload)
typeCastedValuePayload, ok := valuePayload.(*payload.Payload)
if !ok {
filter.getRejectCallback()(message, errors.New("invalid value message"), peer)
return
}
return
}
// reject message if it contains a transaction with invalid signatures
if !typeCastedValuePayload.Transaction().SignaturesValid() {
filter.getRejectCallback()(message, errors.New("invalid transaction signatures"), peer)
// reject message if it contains a transaction with invalid signatures
if !typeCastedValuePayload.Transaction().SignaturesValid() {
filter.getRejectCallback()(message, errors.New("invalid transaction signatures"), peer)
return
}
return
}
// if all previous checks passed: accept message
filter.getAcceptCallback()(message, peer)
})
// if all previous checks passed: accept message
filter.getAcceptCallback()(message, peer)
// })
}
// OnAccept registers the given callback as the acceptance function of the filter.
......
......@@ -29,13 +29,13 @@ func NewMessageSignatureFilter() *MessageSignatureFilter {
}
func (filter *MessageSignatureFilter) Filter(msg *message.Message, peer *peer.Peer) {
filter.workerPool.Submit(func() {
if msg.VerifySignature() {
filter.getAcceptCallback()(msg, peer)
return
}
filter.getRejectCallback()(msg, ErrInvalidSignature, peer)
})
// filter.workerPool.Submit(func() {
if msg.VerifySignature() {
filter.getAcceptCallback()(msg, peer)
return
}
filter.getRejectCallback()(msg, ErrInvalidSignature, peer)
// })
}
func (filter *MessageSignatureFilter) OnAccept(callback func(msg *message.Message, peer *peer.Peer)) {
......
......@@ -39,13 +39,13 @@ func NewPowFilter(worker *pow.Worker, difficulty int) *PowFilter {
// Filter checks whether the given bytes pass the PoW validation and calls the corresponding callback.
func (f *PowFilter) Filter(msgBytes []byte, p *peer.Peer) {
f.workerPool.Submit(func() {
if err := f.validate(msgBytes); err != nil {
f.reject(msgBytes, err, p)
return
}
f.accept(msgBytes, p)
})
// f.workerPool.Submit(func() {
if err := f.validate(msgBytes); err != nil {
f.reject(msgBytes, err, p)
return
}
f.accept(msgBytes, p)
// })
}
// OnAccept registers the given callback as the acceptance function of the filter.
......
......@@ -31,13 +31,13 @@ func NewRecentlySeenBytesFilter() *RecentlySeenBytesFilter {
}
func (filter *RecentlySeenBytesFilter) Filter(bytes []byte, peer *peer.Peer) {
filter.workerPool.Submit(func() {
if filter.bytesFilter.Add(bytes) {
filter.getAcceptCallback()(bytes, peer)
return
}
filter.getRejectCallback()(bytes, ErrReceivedDuplicateBytes, peer)
})
// filter.workerPool.Submit(func() {
if filter.bytesFilter.Add(bytes) {
filter.getAcceptCallback()(bytes, peer)
return
}
filter.getRejectCallback()(bytes, ErrReceivedDuplicateBytes, peer)
// })
}
func (filter *RecentlySeenBytesFilter) OnAccept(callback func(bytes []byte, peer *peer.Peer)) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment