issue 16, 23, 24 merge request

Implements #23 (closed), #16 (closed), #24 (closed)

added 1 commit

• 91c64fb5 - delete .idea

Compare with previous version

changed the description

added 1 commit

• ae8faa15 - issue 24 and 16

Compare with previous version

changed the description

added 1 commit

• 75e1ce2c - change module name and correction previousHash

Compare with previous version

changed title from issue 23 transaction version to issue 16, 23, 24 merge request

assigned to @r17zheng

It would be better if you squash all your commits together to avoid polluting the commit history from main tree. Here is a simple guide : https://davidwalsh.name/squash-commits-git and here is another one that explains a bit more how interactive rebases works: https://thoughtbot.com/blog/git-interactive-rebase-squash-amend-rewriting-history

added 2 commits

• 6718e37a - add .idea to .gitignore
• 02ade5dc - add .idea to .gitignore

Compare with previous version

added 1 commit

• 72f368de - final commit for issuses

Compare with previous version

added 1 commit

• c4264282 - deleta .idea

Compare with previous version

added 1 commit

• b7d6c5db - final commit for issues

Compare with previous version

you should rename this file accordingly to the name of the module to respect project naming conventions

which name ?

Generally speaking, filenames follow the snake_case convention of the module they define. For example, MyApp should be defined inside the my_app.ex

from https://hexdocs.pm/elixir/master/naming-conventions.html#casing

You renamed the module suggestion: you renamed the module PreviousHash, but the file is still named block_hash.ex. The file containing the test case have the same problem

changed this line in version 10 of the diff

i have renamed the file in new commit

You have done a great job with the code, however, I still think this name is not quite right: It should take into account the hierarchy of the files, and be something like: Block.Validation.Local.PreviousHash

ok, the problem has been solved in new commit

added 1 commit

• 3f791237 - final commit for issues

Compare with previous version

added 1 commit

• e11116cd - final commit for issues

Compare with previous version

resolved all threads

approved this merge request

unapproved this merge request

added 1 commit

• dea15912 - rename the module for final commit

Compare with previous version

merged

mentioned in commit 12693e8a