From 784d66336433a14167b22ff4cde6de20b752c2e8 Mon Sep 17 00:00:00 2001 From: Wolfgang Welz <welzwo@gmail.com> Date: Fri, 2 Aug 2019 14:16:49 +0200 Subject: [PATCH] Avoid variable shadowing --- plugins/autopeering/types/peerregister/peer_register.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/plugins/autopeering/types/peerregister/peer_register.go b/plugins/autopeering/types/peerregister/peer_register.go index b90608dd..4b233d94 100644 --- a/plugins/autopeering/types/peerregister/peer_register.go +++ b/plugins/autopeering/types/peerregister/peer_register.go @@ -73,7 +73,9 @@ func (this *PeerRegister) Remove(key string, lock ...bool) { if len(lock) == 0 || lock[0] { defer this.Lock()() - if peerEntry, exists := this.Peers[key]; exists { + // needs to be updated after locking + peerEntry, exists = this.Peers[key] + if exists { delete(this.Peers, key) this.Events.Remove.Trigger(peerEntry) -- GitLab