From 47b0dd95fcdb9651de0877d6cbd28e932ec1da28 Mon Sep 17 00:00:00 2001
From: Hans Moog <hm@mkjc.net>
Date: Thu, 23 Apr 2020 14:42:28 +0200
Subject: [PATCH] Apply suggestions from code review
Co-Authored-By: Wolfgang Welz <welzwo@gmail.com>
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
---
packages/binary/valuetransfer/transaction/transaction.go | 6 +++---
.../binary/valuetransfer/transaction/transaction_test.go | 3 +++
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/packages/binary/valuetransfer/transaction/transaction.go b/packages/binary/valuetransfer/transaction/transaction.go
index dfca7227..b1b4a918 100644
--- a/packages/binary/valuetransfer/transaction/transaction.go
+++ b/packages/binary/valuetransfer/transaction/transaction.go
@@ -276,7 +276,7 @@ func (transaction *Transaction) String() string {
// max dataPayload size limit
const MAX_DATA_PAYLOAD_SIZE = 64 * 1024
-// sets yhe dataPayload and its type
+// SetDataPayload sets yhe dataPayload and its type
func (transaction *Transaction) SetDataPayload(data []byte) error {
transaction.dataPayloadMutex.Lock()
defer transaction.dataPayloadMutex.Unlock()
@@ -288,7 +288,7 @@ func (transaction *Transaction) SetDataPayload(data []byte) error {
return nil
}
-// gets the dataPayload and its type
+// GetDataPayload gets the dataPayload and its type
func (transaction *Transaction) GetDataPayload() []byte {
transaction.dataPayloadMutex.RLock()
defer transaction.dataPayloadMutex.RUnlock()
@@ -296,7 +296,7 @@ func (transaction *Transaction) GetDataPayload() []byte {
return transaction.dataPayload
}
-// return size of the dataPayload as uint32
+// DataPayloadSize returns the size of the dataPayload as uint32.
// nil payload as size 0
func (transaction *Transaction) DataPayloadSize() uint32 {
transaction.dataPayloadMutex.RLock()
diff --git a/packages/binary/valuetransfer/transaction/transaction_test.go b/packages/binary/valuetransfer/transaction/transaction_test.go
index 7235fffd..0a92d549 100644
--- a/packages/binary/valuetransfer/transaction/transaction_test.go
+++ b/packages/binary/valuetransfer/transaction/transaction_test.go
@@ -5,6 +5,9 @@ import (
"strings"
"testing"
+ "strings"
+ "testing"
+
"github.com/iotaledger/goshimmer/packages/binary/valuetransfer/address"
"github.com/iotaledger/goshimmer/packages/binary/valuetransfer/address/signaturescheme"
"github.com/iotaledger/goshimmer/packages/binary/valuetransfer/balance"
--
GitLab