From e72373194b8241beac59b81759c94c1929749841 Mon Sep 17 00:00:00 2001
From: Levente Pap <levente.pap@iota.org>
Date: Wed, 15 Jul 2020 17:07:27 +0200
Subject: [PATCH] Small fixes
---
plugins/metrics/plugin.go | 3 ++-
plugins/prometheus/tangle.go | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/plugins/metrics/plugin.go b/plugins/metrics/plugin.go
index da6f20e0..25063ec6 100644
--- a/plugins/metrics/plugin.go
+++ b/plugins/metrics/plugin.go
@@ -110,10 +110,11 @@ func registerLocalMetrics() {
// messages can only become solid once, then they stay like that, hence no .Dec() part
messagelayer.Tangle().Events.MessageSolid.Attach(events.NewClosure(func(cachedMessage *message.CachedMessage, cachedMessageMetadata *tangle.CachedMessageMetadata) {
- defer cachedMessage.Release()
+ cachedMessage.Release()
messageSolidCountDBInc.Inc()
solidTimeMutex.Lock()
defer solidTimeMutex.Unlock()
+ // Consume should release cachedMessageMetadata
cachedMessageMetadata.Consume(func(object objectstorage.StorableObject) {
msgMetaData := object.(*tangle.MessageMetadata)
sumSolidificationTime += msgMetaData.SolidificationTime().Sub(msgMetaData.ReceivedTime())
diff --git a/plugins/prometheus/tangle.go b/plugins/prometheus/tangle.go
index 18561f6a..10e7ef4f 100644
--- a/plugins/prometheus/tangle.go
+++ b/plugins/prometheus/tangle.go
@@ -44,7 +44,7 @@ func registerTangleMetrics() {
})
messageSolidCountDB = prometheus.NewGauge(prometheus.GaugeOpts{
- Name: "tangle_message_solid_count",
+ Name: "tangle_message_solid_count_db",
Help: "number of solid messages on the node's database",
})
--
GitLab