From d7962911065d196bc67973ed3eb8762118210433 Mon Sep 17 00:00:00 2001
From: capossele <angelocapossele@gmail.com>
Date: Thu, 23 Jan 2020 15:11:49 +0000
Subject: [PATCH] :loud_sound: improves debug logs

---
 plugins/analysis/client/plugin.go                        | 9 +++++----
 .../webinterface/recordedevents/recorded_events.go       | 6 ++++++
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/plugins/analysis/client/plugin.go b/plugins/analysis/client/plugin.go
index df532eec..f3ad4f70 100644
--- a/plugins/analysis/client/plugin.go
+++ b/plugins/analysis/client/plugin.go
@@ -1,6 +1,7 @@
 package client
 
 import (
+	"encoding/hex"
 	"net"
 	"time"
 
@@ -57,19 +58,19 @@ func Run(plugin *node.Plugin) {
 func getEventDispatchers(conn *network.ManagedConnection) *EventDispatchers {
 	return &EventDispatchers{
 		AddNode: func(nodeId []byte) {
-			log.Debugw("AddNode", "nodeId", nodeId)
+			log.Debugw("AddNode", "nodeId", hex.EncodeToString(nodeId))
 			_, _ = conn.Write((&addnode.Packet{NodeId: nodeId}).Marshal())
 		},
 		RemoveNode: func(nodeId []byte) {
-			log.Debugw("RemoveNode", "nodeId", nodeId)
+			log.Debugw("RemoveNode", "nodeId", hex.EncodeToString(nodeId))
 			_, _ = conn.Write((&removenode.Packet{NodeId: nodeId}).Marshal())
 		},
 		ConnectNodes: func(sourceId []byte, targetId []byte) {
-			log.Debugw("ConnectNodes", "sourceId", sourceId, "targetId", targetId)
+			log.Debugw("ConnectNodes", "sourceId", hex.EncodeToString(sourceId), "targetId", hex.EncodeToString(targetId))
 			_, _ = conn.Write((&connectnodes.Packet{SourceId: sourceId, TargetId: targetId}).Marshal())
 		},
 		DisconnectNodes: func(sourceId []byte, targetId []byte) {
-			log.Debugw("DisconnectNodes", "sourceId", sourceId, "targetId", targetId)
+			log.Debugw("DisconnectNodes", "sourceId", hex.EncodeToString(sourceId), "targetId", hex.EncodeToString(targetId))
 			_, _ = conn.Write((&disconnectnodes.Packet{SourceId: sourceId, TargetId: targetId}).Marshal())
 		},
 	}
diff --git a/plugins/analysis/webinterface/recordedevents/recorded_events.go b/plugins/analysis/webinterface/recordedevents/recorded_events.go
index ae6a5597..398ca970 100644
--- a/plugins/analysis/webinterface/recordedevents/recorded_events.go
+++ b/plugins/analysis/webinterface/recordedevents/recorded_events.go
@@ -16,6 +16,7 @@ var lock sync.Mutex
 
 func Configure(plugin *node.Plugin) {
 	server.Events.AddNode.Attach(events.NewClosure(func(nodeId string) {
+		plugin.Node.Logger.Debugw("AddNode", "nodeID", nodeId)
 		lock.Lock()
 		defer lock.Unlock()
 
@@ -25,6 +26,7 @@ func Configure(plugin *node.Plugin) {
 	}))
 
 	server.Events.RemoveNode.Attach(events.NewClosure(func(nodeId string) {
+		plugin.Node.Logger.Debugw("RemoveNode", "nodeID", nodeId)
 		lock.Lock()
 		defer lock.Unlock()
 
@@ -32,6 +34,7 @@ func Configure(plugin *node.Plugin) {
 	}))
 
 	server.Events.NodeOnline.Attach(events.NewClosure(func(nodeId string) {
+		plugin.Node.Logger.Debugw("NodeOnline", "nodeID", nodeId)
 		lock.Lock()
 		defer lock.Unlock()
 
@@ -39,6 +42,7 @@ func Configure(plugin *node.Plugin) {
 	}))
 
 	server.Events.NodeOffline.Attach(events.NewClosure(func(nodeId string) {
+		plugin.Node.Logger.Debugw("NodeOffline", "nodeID", nodeId)
 		lock.Lock()
 		defer lock.Unlock()
 
@@ -46,6 +50,7 @@ func Configure(plugin *node.Plugin) {
 	}))
 
 	server.Events.ConnectNodes.Attach(events.NewClosure(func(sourceId string, targetId string) {
+		plugin.Node.Logger.Debugw("ConnectNodes", "sourceID", sourceId, "targetId", targetId)
 		lock.Lock()
 		defer lock.Unlock()
 
@@ -59,6 +64,7 @@ func Configure(plugin *node.Plugin) {
 	}))
 
 	server.Events.DisconnectNodes.Attach(events.NewClosure(func(sourceId string, targetId string) {
+		plugin.Node.Logger.Debugw("DisconnectNodes", "sourceID", sourceId, "targetId", targetId)
 		lock.Lock()
 		defer lock.Unlock()
 
-- 
GitLab